Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ISOMIP+ plotting #705

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix ISOMIP+ plotting #705

merged 1 commit into from
Sep 28, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Sep 28, 2023

We need to make what was an argument to Polygon before a keyword argument closed=True for compatibility with more recent versions of matplotlib.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

We need to make what was an argument to `Polygon` before
a keywork argument `closed=True` for compatibility with more
recent versions of matplotlib.
@xylar xylar added bug Something isn't working ocean labels Sep 28, 2023
@xylar xylar self-assigned this Sep 28, 2023
@xylar
Copy link
Collaborator Author

xylar commented Sep 28, 2023

Equivalent fixes were made in Polaris in E3SM-Project/polaris#121.

@xylar
Copy link
Collaborator Author

xylar commented Sep 28, 2023

Testing

This was tested as part of the pr suite on Chicoma for #704. Whereas ocean/isomip_plus/planar/2km/z-star/Ocean0 failed when run from main, it succeeded with the fix from this branch (though validation, of course, failed because there was no baseline).

@xylar xylar merged commit dc381b5 into MPAS-Dev:main Sep 28, 2023
@xylar xylar deleted the fix-isomip-plus-plotting branch September 28, 2023 12:46
This was referenced Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant