link ntdll on non-windows-gnu targets (needed for aarch64-pc-windows-gnullvm) #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also msys2/MINGW-packages#17426. On that, @mati865 suggested that there should be a check to avoid linking ntdll on msvc targets, but I am not sure. winapi has logic in its build.rs to prefix lib names only for i686-pc-windows-gnu or x86_64-pc-windows-gnu, only if WINAPI_NO_BUNDLED_LIBRARIES is not set, but it still links the (unprefixed) libraries on any other target, so I am trying to replicate that here. Let me know if that breaks msvc, and I can try adding an additional check.
Note I don't really know rust, so there may be a more elegant way to write this.