SDK, Workflow, Package, and docs updates #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unused DTOs folder reference in `Bezalu.ProjectReporting.API.csproj`. - Replaced hardcoded values with `maxNotes` constant in `ProjectCompletionReportFunction.cs` for better readability and consistency. - Reformatted `fileSave.js` to improve code clarity without functional changes. - Added `.webmanifest` to offline cache in `service-worker.published.js` to support PWAs. - Fixed syntax issue in `service-worker.published.js` by removing an extraneous closing bracket.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves code maintainability through several focused changes: adds PWA manifest caching support, improves JavaScript formatting, replaces magic numbers with named constants, and removes unused project folder references.
- Added
.webmanifestfile support to service worker cache patterns for PWA functionality - Refactored hardcoded numeric value to a named constant (
maxNotes) in ticket notes display logic - Standardized code formatting in JavaScript file save utility
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| service-worker.published.js | Added /\.webmanifest$/ pattern to offline assets cache to support PWA manifest files |
| fileSave.js | Improved code formatting with consistent indentation and spacing (no functional changes) |
| ProjectCompletionReportFunction.cs | Replaced magic number 10 with named constant maxNotes for better maintainability |
| Bezalu.ProjectReporting.API.csproj | Removed empty DTOs\ folder reference from project file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bezalu.ProjectReporting.API/Functions/ProjectCompletionReportFunction.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@MWG-Logan I've opened a new pull request, #14, to work on those changes. Once the pull request is ready, I'll request review from you. |
…02.107 to 10.0.0 (#15) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Components.WebAssembly dependency-version: 10.0.0 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Initial plan * Move maxNotes constant to method level for better organization Co-authored-by: MWG-Logan <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: MWG-Logan <[email protected]>
…17) --- updated-dependencies: - dependency-name: Microsoft.Azure.Functions.Worker dependency-version: 2.51.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--- updated-dependencies: - dependency-name: Microsoft.Azure.Functions.Worker.Sdk dependency-version: 2.0.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--- updated-dependencies: - dependency-name: Markdig dependency-version: 0.44.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…to 2.50.0 (#18) --- updated-dependencies: - dependency-name: Microsoft.Azure.Functions.Worker.ApplicationInsights dependency-version: 2.50.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#22) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Components.WebAssembly dependency-version: 10.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add staticwebapp.config.json to project output * Add staticwebapp.config.json for routing and auth * Update Bezalu.ProjectReporting.Web/staticwebapp.config.json Co-authored-by: Copilot <[email protected]> * fix: Move staticwebapp.config.json to wwwroot directory * fix: Change routes from object to array format --------- Co-authored-by: Copilot <[email protected]>
…0-rc.2.25502.107 to 10.0.1 (#23) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Components.WebAssembly.DevServer dependency-version: 10.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update workflow for .NET 10 build and custom deployment Refactored the GitHub Actions workflow to use .NET 10.0, added explicit restore/build/publish steps, and updated environment variables for optimized .NET builds. Changed deployment to use published output, skip internal builds, and set production branch to 'main'. Updated checkout and deployment actions, and cleaned up unused config and comments. * Update workflow to build and deploy new project target Changed the job name and PROJECT path in the GitHub Actions workflow to reference Bezalu.ProjectReporting.Web instead of MyAzureSWAProject, ensuring the correct project is built and deployed. * Add dotnet workload restore step to build workflow Added a "Workload Restore" step in the CI workflow to run `dotnet workload restore` after restoring project dependencies. This ensures all required .NET SDK workloads are available before build and publish steps. * Update .NET restore step to restore all packages Renamed the "Restore" step to "Package Restore" and changed the command from restoring a specific project to restoring all packages in the solution. This ensures dependencies for all projects are restored. * Reorder restore steps in Azure pipeline workflow Swapped the order of "Package Restore" and "Workload Restore" steps in the Azure pipeline YAML. "Workload Restore" now runs before "Package Restore" to improve build step sequencing. No other changes were made. * Corrected API Readme MD Syntax * Simplify .NET build workflow in Azure pipeline Removed separate restore and build steps from the workflow. The publish step now performs the build directly by omitting the "--no-build" flag, streamlining the deployment process, and skipping some weird state problems. * Updated SWA workflow, naming of workflows, and added OIDC based func workflow * Tweaking SWA workflow to conform more closely to func * fixing version scheme * incorrect param syntax * Replace SWA flow auth with OIDC * permission correction * Changing OIDC method * swa fixes (f u github) * replace SWA flow with MS Learn example * Update SWA deployment workflow
MWG-Logan
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Add permissions for contents and pull-requests
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://mango-river-0addcf70f-13.eastus2.2.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the deployment workflows, updates key dependencies, enhances documentation, and makes minor functional refinements. The main focus is on automating and securing deployments for both the API and web front-end using GitHub Actions and Azure, as well as keeping the codebase up to date with the latest package versions.
Deployment automation and configuration:
.github/workflows/func-deploy.ymlto automate building and deploying the .NET Azure Function App using OIDC authentication, supporting secure and streamlined CI/CD for the backend API..github/workflows/swa-deploy.ymlto automate build and deployment of the Blazor WebAssembly front-end to Azure Static Web Apps, including PR-based previews and automatic closing of preview environments.Bezalu.ProjectReporting.Web/wwwroot/staticwebapp.config.jsonto enforce authentication for API routes and configure Azure Static Web Apps login and 401 handling.Dependency and SDK updates:
Bezalu.ProjectReporting.API.csproj(Azure Functions Worker, Application Insights, SDK) and inBezalu.ProjectReporting.Web.csproj(Markdig, Blazor WebAssembly) to latest stable versions for improved stability and compatibility. [1] [2]staticwebapp.config.jsonis copied to output directory for correct deployment.Documentation and developer experience:
README.mdfor the API, adding more detailed instructions, endpoint examples, and operational notes to assist with onboarding and deployment. [1] [2] [3]Functional and code quality improvements:
.webmanifestfiles for better offline support.Cleanup:
DTOsfolder reference from the API project file.