feat: Add configurable endpoint option #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new initializer that accepts a fully configured endpoint URL. - The existing initializer (accepting `host`, `port`, and `scheme`) remains available and now also configures the endpoint. - Converted the previously stored `host`, `port`, and `scheme` properties to computed properties based on the endpoint to maintain API compatibility.
|
Base on #221 it might make sense to rewrite the code to not include the |
This update allows the `endpoint:URL` to specify the entire `basePath`, including the version path segment (e.g., `/v1`).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds fully customizable endpoint support. Instead of "just" adding
basePathyou can now pass a fully configured endpoint URL.Why
Internal/hosted OpenAI Instances sometimes use different paths to host the OpenAI endpoint. Previous versions of the framework only allowed for changing
scheme,hostandport. As changing thebasePathis a common requirement (and also supported by frameworks in other languages) this PR adds fully customisable endpoint support - incl. thebasePath.Affected Areas
endpoint: URL.host,port, andscheme) remains available and now also configures the endpoint.host,port, andschemeproperties to computed properties based on the endpoint to maintain API compatibility.