Skip to content

Adding "isSecure" option #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jgarciaghw wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding "isSecure" option #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa7d223
Adding isSecure Feature
jgarciaghw May 13, 2016
c3cf0ab
Updating README.md
jgarciaghw May 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ node_modules/
.DS_Store
*/.DS_Store
*.txt
*.log
*.log
.idea
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ var magento = new MagentoAPI({
port: 80,
path: '/api/xmlrpc/',
login: 'your_username',
pass: 'your_pass'
pass: 'your_pass',
isSecure: false
});

magento.login(function(err, sessId) {
Expand Down
6 changes: 4 additions & 2 deletions src/magento.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ var configDefaults = {
path: mandatory,
login: mandatory,
pass: mandatory,
parallelLimit: Infinity
parallelLimit: Infinity,
isSecure: false
};

/**
Expand All @@ -61,6 +62,7 @@ var configDefaults = {
@param {Number} [config.parallelLimit] How many requests to make in parallel, defaults to Infinity
@param {String} config.login Login username
@param {String} config.pass Login password
@param {Boolean} config.isSecure
*/
function Magento(config) {
var self = this;
Expand All @@ -77,7 +79,7 @@ function Magento(config) {
}

this.config = magentoConfig;
this.client = xmlrpc.createClient(this.config);
this.client = this.config.isSecure ? xmlrpc.createSecureClient(this.config) : xmlrpc.createClient(this.config);
this.queue = [];
this.queue.running = 0;
this.queue.parallelLimit = this.config.parallelLimit;
Expand Down