Repository navigation
Nametags: Let a player show their own nametag - #308
Conversation
Nametags.setSelfVisible/isSelfVisible flip NameTagView::showSelf, off by default. The mod's draw pass owns how the local avatar's tag is drawn.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughAdds scripting methods to set and query local-player nametag visibility. The value is stored in ChangesLocal-player nametag visibility
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to This adds an opt-in switch for showing the local player's own nametag. It is off by default, so existing behavior is unchanged. No merge-blocking risk was found. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the nametag glow, Comment |
A client script can now show the local player's own nametag: the same tag the others see over them, with any
Nametags.setLabelline on their own id. Until now the only way was projecting it fromCamera.capture(), which never matched the native style or occlusion.Nametags.setSelfVisible(visible)/Nametags.isSelfVisible()setNameTagView::showSelf, next toshowTagsandshowHealth.Default is off, so existing mods behave exactly as before.
Tested: HogwartsMP builds against it (
nametag_self_visible) and draws the tag in game, checked by an automated QA run: off by default, on with a label, faded with the camera up close, off again. FrameworkTests 651/651.Summary by CodeRabbit