Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MafiaMP duplicates its window-message input backend and polls camera controls directly through Win32. Mouse messages use the modifier mask as an array index and repeated keydowns create repeated press edges. This reuses framework acquisition and routes camera controls through the common
IInputquery API.Changes
GameInputfrom frameworkWindowInput, retaining native locking and cursor presentation.IInput::IsKeyDownand existingFW_KEY_*macros, with native conversion inside the adapter.Dependency and scope
Depends on Framework #292, pinned to
689c27139ba8e0123e33cfb54f869d27f15c7001for review. Existing build paths must use that checkout; merge Framework first and replace the review pin with its merged commit before release. VERSION is unchanged.MafiaMP is excluded from the framework's discovered projects by IGNORE. This draft covers input migration; compatibility of the entire legacy project with current Framework APIs is not established. Existing widget/frame timing, camera math, cursor movement and custom chat UI remain unchanged. Complete ChatBox/CEF migrations remain follow-ups.
Validation
The shared implementation was built and tested in Framework #292: 12 portable cases passed on Linux; the canonical MSVC x64 Debug input unit target ran under Wine with 30 cases passed and one real English/Russian/AZERTY layout case skipped. The runner includes the skipped case in its aggregate total of 31, so it is not counted here as verified layout coverage.
git diff --checkpassed. No client, launcher, server or stress executable was launched. No full game-target build or runtime integration result is claimed. Native Windows compilation, real keyboard-layout behavior and in-game focus/UI transitions still need validation.