Static Type-checking for httptools #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DABND19
reviewed
Jul 17, 2024
httptools/parser/url_parser.pyi
Outdated
| fragment:bytes | ||
| userinfo:bytes | ||
|
|
||
| def parse_url(url:Union[bytes, bytearray, memoryview, array]) -> URL: |
There was a problem hiding this comment.
I think you should add spaces after colons for type annotations
|
On Wed, Jul 17, 2024 at 5:11 AM David Grigorenko ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In httptools/parser/url_parser.pyi
<#100 (comment)>:
> @@ -0,0 +1,29 @@
+from typing import Union
+from array import array
+
+class URL:
+ schema:bytes
+ host:bytes
+ port:int
+ path:bytes
+ query:bytes
+ fragment:bytes
+ userinfo:bytes
+
+def parse_url(url:Union[bytes, bytearray, memoryview, array]) -> URL:
I think you should add spaces after colons for type annotations
—
Reply to this email directly, view it on GitHub
<#100 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3K7GGVIXG426I4JPGQSNXDZMY7MVAVCNFSM6AAAAABKCSKGNSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBSGQ4TAMBXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
Thanks for your input I will make sure that I add that in.
|
unblock upstream PR
|
@DABND19 could you take a look? thanks |
Hi! I am not the maintainer of this repository, I just left my comments on this pull request :) |
|
thanks for the help. I was off doing other things that I had forgotten about this completely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt the need to add static type-checking to this library in order to help other programmers with using this library. I hope this pull request will help out a few people with using this library.