Implement clear auth for gift card mints by jbojcic1 · Pull Request #958 · MakePrisms/agicash

jbojcic1 · 2026-03-25T15:20:04Z

Implements #957

supabase · 2026-03-25T15:20:12Z

This pull request has been ignored for the connected project hrebgkfhjpkbxpztqqke because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

vercel · 2026-03-25T15:20:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agicash	Ready	Preview, Comment	Apr 1, 2026 9:59pm

jbojcic1 · 2026-03-25T15:20:31Z

Not ready for review yet. I am not happy with some stuff here so will iterate

jbojcic1 · 2026-04-01T16:17:53Z

app/features/receive/cashu-receive-quote-hooks.ts

    quotes: pendingMeltQuotes,
+    getWallet: (mintUrl) => {
+      const sourceAccount = getCashuAccountByMintUrl(mintUrl);
+      const authProvider = getMintAuthProvider(sourceAccount?.purpose);


at the moment we have to check if there is existing account for mint url and if yes what is the purpose to decide which (if any) auth provider is needed

I don't see another way to do it. unless we want to:
a) make getCashuWallet async and call mint info first to get purpose from there
b) make list of gift card accounts somewhere static so getCashuWallet can read it

jbojcic1 · 2026-04-01T16:20:49Z

app/features/shared/cashu.ts

  blocklist: mintBlocklist,
 });

+type MintPurpose = 'gift-card' | 'transactional';


i don't want to import purpose from accounts folder becaue shared feature shouldn't import non shared one. I was thinking to import it from /lib/cash protocol extensions but it's not there. @gudnuf didn't we change how we expose that stuff in mint info to include purpose?

Yea, but that's in my open PRs for offers. In the agicash PR to support offer mints I exported MintPurpose here. Then here I reexported it as AccountPurpose because spark accounts have a purpose of transactional

we can update this then once that gets merged

docs/superpowers/plans/2026-03-25-clear-auth-wallet.md

gudnuf · 2026-04-01T20:50:10Z

app/features/shared/cashu.ts

  blocklist: mintBlocklist,
 });

+type MintPurpose = 'gift-card' | 'transactional';


Yea, but that's in my open PRs for offers. In the agicash PR to support offer mints I exported MintPurpose here. Then here I reexported it as AccountPurpose because spark accounts have a purpose of transactional

gudnuf · 2026-04-01T20:51:53Z

app/features/receive/cashu-receive-quote-hooks.ts

+      const sourceAccount = getCashuAccountByMintUrl(sourceMintUrl);
+
+      const sourceWallet = getCashuWallet(sourceMintUrl, {
+        unit: cashuUnit,


The account should have the wallet on it already, why use getCashuWallet here instead of just sourceAccount.wallet?

good point. I forgot that

i changed it so that it uses that wallet and calls getCashuWallet only if there is no account for that mint url

gudnuf · 2026-04-01T20:53:16Z

app/features/accounts/account-hooks.ts

 }

+/**
+ * Hook to get the method which returns the first cashu account matching a mint URL, or null if not found.


What if you have a USD and BTC account with same mint URL?

good point. fixed

gudnuf · 2026-04-01T20:55:19Z

app/features/shared/cashu.ts

@@ -39,6 +40,7 @@ import { type Currency, type CurrencyUnit, Money } from '~/lib/money';
 import { measureOperation } from '~/lib/performance';
 import { computeSHA256 } from '~/lib/sha256';
 import { getSeedPhraseDerivationPath } from '../accounts/account-cryptography';


to your comment on importing to shared from non-shared, just btw this does that.

i know. I noticed that too but didn't want to make unrelated changes now. we need to clean that up and possibly reorganize some other stuff too (e.g. perhaps bunch of stuff from accounts need to go to shared etc)

Add NUT-21 Clear Auth support so gift card mints can protect endpoints. - Add getAgicashMintAuthProvider in features/shared/agicash-mint-auth-provider.ts with React Query caching (shared across all gift card mints) - Add getMintAuthProvider(purpose) in features/shared/cashu.ts to map account purpose to the appropriate auth provider - Add useGetCashuAccountByMintUrlAndCurrency hook for looking up accounts - Pass auth provider to getCashuWallet for gift card accounts in: account-repository, user-repository, receive hooks, send hooks - Add getWallet callback to useOnMeltQuoteStateChange so callers control wallet construction with auth - Change getInitializedCashuWallet to use named params object - Extract isLoggedIn to features/shared/auth.ts - Delete implementation plan doc Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jbojcic1 requested a review from gudnuf March 25, 2026 15:20

jbojcic1 self-assigned this Mar 25, 2026

vercel bot deployed to Preview March 25, 2026 15:20 View deployment

orveth assigned gudnuf and jbojcic1 and unassigned gudnuf and jbojcic1 Mar 28, 2026

vercel bot deployed to Preview April 1, 2026 14:18 View deployment

vercel bot deployed to Preview April 1, 2026 15:01 View deployment

vercel bot deployed to Preview April 1, 2026 15:07 View deployment

vercel bot deployed to Preview April 1, 2026 15:11 View deployment

vercel bot deployed to Preview April 1, 2026 15:19 View deployment

vercel bot deployed to Preview April 1, 2026 15:21 View deployment

vercel bot deployed to Preview April 1, 2026 15:54 View deployment

vercel bot deployed to Preview April 1, 2026 16:10 View deployment

vercel bot deployed to Preview April 1, 2026 16:13 View deployment

ditto-agent force-pushed the impl/clear-auth-wallet-authprovider branch from de5f2da to 262e6f1 Compare April 1, 2026 16:14

vercel bot deployed to Preview April 1, 2026 16:15 View deployment

ditto-agent force-pushed the impl/clear-auth-wallet-authprovider branch from 262e6f1 to 7ec10a1 Compare April 1, 2026 16:15

vercel bot deployed to Preview April 1, 2026 16:16 View deployment

jbojcic1 commented Apr 1, 2026

View reviewed changes

ditto-agent force-pushed the impl/clear-auth-wallet-authprovider branch from 7ec10a1 to bb72ec7 Compare April 1, 2026 16:21

jbojcic1 commented Apr 1, 2026

View reviewed changes

docs/superpowers/plans/2026-03-25-clear-auth-wallet.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview April 1, 2026 16:23 View deployment

ditto-agent force-pushed the support-clear-auth-with-shared-secret branch from 0610474 to 1de1aac Compare April 1, 2026 18:56

ditto-agent force-pushed the impl/clear-auth-wallet-authprovider branch from bb72ec7 to 66e951c Compare April 1, 2026 18:57

vercel bot deployed to Preview April 1, 2026 18:59 View deployment

gudnuf reviewed Apr 1, 2026

View reviewed changes

ditto-agent force-pushed the impl/clear-auth-wallet-authprovider branch from 66e951c to a5330bd Compare April 1, 2026 21:45

vercel bot deployed to Preview April 1, 2026 21:46 View deployment

ditto-agent force-pushed the impl/clear-auth-wallet-authprovider branch from 1a8c5c2 to 839bfb3 Compare April 1, 2026 21:57

vercel bot deployed to Preview April 1, 2026 21:59 View deployment

jbojcic1 requested a review from gudnuf April 1, 2026 21:59

Conversation

jbojcic1 commented Mar 25, 2026

Uh oh!

supabase bot commented Mar 25, 2026

Uh oh!

vercel bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbojcic1 commented Mar 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel bot commented Mar 25, 2026 •

edited

Loading