plan to refactor agicash workspace for agicash-cli#962
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the full SDK extraction plan for refactoring agicash into a bun workspace with an
@agicash/sdkpackage.What the plan covers:
8 phases, each shipping as one independently-verifiable PR:
packages/sdk/)app/lib/portable modules (money, cashu, bolt11, spark, etc.)app/features/shared/portable code@agicash/sdk5 audited critical issues with fixes (from 2026-03-27 review):
setQueryData()/invalidateQueries()missing from Cache typegetFeatureFlagin portable code — needs migration toAgicashConfig.featureFlagsimport.meta.envin cashu.ts — needs lazy function callArchitecture: web app stays at root,
packages/sdk/is the only new directory, no monorepo tooling beyond bun workspacesPrinciples: move files don't rewrite them, shims then cleanup, no new abstractions except at real boundaries