Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
orveth
left a comment
There was a problem hiding this comment.
clean removal — no leftover references, imports correctly dropped, balance logic still works.
two things:
-
stale comments above
updateSparkAccountBalancestill reference the workaround that no longer exists ("This is used for a Spark bug workaround...", "TODO: Update when Spark bug is fixed"). worth cleaning up or removing since the function now does the simple thing those comments wished for. -
the old code gated updates on
versionOkordering — that's gone now. fine for a diagnostic change, but if this sticks around longer term, worth thinking about whether you still want version ordering to prevent stale updates from racing.
otherwise looks good, makes sense as a diagnostic step alongside #964's debug logging.
I want to temporarily remove this and verify if that 0 balance bug is also happening due to Spark SDK stream connection issues.