Skip to content

Temporarily remove spark balance workaround#965

Open
jbojcic1 wants to merge 1 commit intomasterfrom
remove-spark-balance-workaround
Open

Temporarily remove spark balance workaround#965
jbojcic1 wants to merge 1 commit intomasterfrom
remove-spark-balance-workaround

Conversation

@jbojcic1
Copy link
Copy Markdown
Collaborator

I want to temporarily remove this and verify if that 0 balance bug is also happening due to Spark SDK stream connection issues.

@jbojcic1 jbojcic1 self-assigned this Mar 30, 2026
@supabase
Copy link
Copy Markdown

supabase bot commented Mar 30, 2026

This pull request has been ignored for the connected project hrebgkfhjpkbxpztqqke because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agicash Ready Ready Preview, Comment Mar 30, 2026 2:20pm

Request Review

Copy link
Copy Markdown

@orveth orveth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean removal — no leftover references, imports correctly dropped, balance logic still works.

two things:

  1. stale comments above updateSparkAccountBalance still reference the workaround that no longer exists ("This is used for a Spark bug workaround...", "TODO: Update when Spark bug is fixed"). worth cleaning up or removing since the function now does the simple thing those comments wished for.

  2. the old code gated updates on versionOk ordering — that's gone now. fine for a diagnostic change, but if this sticks around longer term, worth thinking about whether you still want version ordering to prevent stale updates from racing.

otherwise looks good, makes sense as a diagnostic step alongside #964's debug logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants