refactor: unify offer and gift card rendering patterns#973
Merged
gudnuf merged 1 commit intofeat/offers-ui-v2from Apr 1, 2026
Merged
refactor: unify offer and gift card rendering patterns#973gudnuf merged 1 commit intofeat/offers-ui-v2from
gudnuf merged 1 commit intofeat/offers-ui-v2from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
orveth
commented
Mar 31, 2026
Author
orveth
left a comment
There was a problem hiding this comment.
keeper:review: PASS
Verified:
- All
offer-card-images.ts/offer-item.tsxreferences removed (grepped full app/ tree) CARD_IMAGESconsolidation covers thelocalhost:8104entry from deleted filehideOverlayContentproperly typed (boolean?) and consumed inGiftCardItem- 2-way render in
receive-cashu-token.tsxcovers all prior 3-way cases loadOfferCardsFromEnv()retained — startup validation still enforced
Clean unification. Needs gudnuf or josip approval to merge.
gudnuf
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CARD_IMAGESmap withgetCardByUrl()lookupOfferItemwithGiftCardItem+hideOverlayContentprop for consistent card renderingreceive-cashu-token.tsxto 2-way (gift-card/offer share the same card image path)offer-card-images.tsandoffer-item.tsx(no longer needed)Addresses review comments #3 and #4 on PR #968.
Test plan
🤖 Generated with Claude Code