-
Notifications
You must be signed in to change notification settings - Fork 1
Update package.json, add package-lock.json, remove unused watch task #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| }); | ||
|
|
||
| // Watch for changes | ||
| gulp.task('watch', ['build'], function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this removal is correct as it was practically duplicated. I'd love to have some 'watch only' feature without the 'serve'. Since there were times I needed to add PHP to the project and work through Apache (opening the project in the browser as http://localhost), the 'serve' in my case was useless, yet the watch is a great thing to have, so you can see the changes by manually refreshing.
Nice change, maybe at some point we can rearrange the tasks having 'run' for build, watch and serve and another task 'watch' as build and watch only (maybe 'run' may call 'watch' and 'serve').
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Future note: I'm not crazy about leaving the package-lock.json file in the project, since I believe this is more useful in a work in progress rather than in a framework for a fresh-start. Maybe we can consider removing it in a future update.
|
if we're going to remove the package-lock then we should add it in the |
|
I'm not sure about that, since once you started with a new project, it's a good thing to share the lock file within the devs, so everybody shares the same npm dependencies. Is just that keeping a lock file that most likely will be outdated when starting a project doesn't make much sense to me. If we add it to the |
|
yes, and that's why I suggest using it, since NPM autogenerates that file, once you're starting a new project and want to lock dependencies yo do it an the package-lock gets updated and fixed too. |
|
Fair enough. |
Background
Dependencies were outdated, and package-lock (introduced in npm 5.0) was missing
Changes done