fix(governance): align PR types with canonical labels#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The v1.3.2 strict workflow first required a valid Conventional Commit PR title such as fix, then converted that type literally to type:fix. The canonical taxonomy contains type:bug instead, so a correctly titled and labeled bug PR could never pass. The qualitative precheck duplicated the same broken mapping. Shared workflows also retained checkout v4 and emitted Node 20 and punycode deprecation warnings.
Acceptance criteria
Out of scope
Validation
Adversarial review
Claude Fable 5 at xhigh identified the issue-title compatibility domain, the non-spec bang position, the missing self-CI, and the need for a complete codomain check. Those findings are adopted. Its suggested v1.1.0 tag was rejected because live tags already reach v1.3.2; this delivery targets v1.4.0. actionlint was not added because it is unavailable locally and is not needed to prove this root cause; the new pin regression and hosted workflow provide the relevant evidence.
Refs Malakof/crystal-platform#409.
Blocks Malakof/crystal-capabilities#7.