Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add new branch checklist doc #188

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Feb 23, 2021

@chessbyte Please review.

I keep this document locally, but it makes more sense to commit it here. WIP because I am mid-branching; some things are checked off and other parts are still incomplete. After branch is complete, I'll clean this up, clear all the checkboxes, and we can merge this.

@Fryguy Fryguy force-pushed the new_branch_checklist branch 4 times, most recently from 6e0a8dd to 32985ed Compare February 23, 2021 04:30
@Fryguy Fryguy force-pushed the new_branch_checklist branch from 32985ed to 7cbddb7 Compare February 23, 2021 04:34
| `<NextBranch>` | Next branch name titleized | `Morphy` |
| `<nextbranch#>` | Next branch number | `13` |
| `<nextbranch>` | Next branch name | `morphy` |
| `<n+2branch>` | Unnamed N+2 branch | `N-release` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be more helpful if I have the n+2 branch name, so it is not "unnamed"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only place it's really used is here, which is stating when deprecations are expected to be removed.

https://github.com/ManageIQ/manageiq/blob/c43b2093199bb6942318c3102371b79c03f95473/lib/vmdb/deprecation.rb#L4

Fryguy and others added 2 commits February 24, 2021 12:58
@Fryguy Fryguy force-pushed the new_branch_checklist branch from ec2774a to 1af4c5a Compare March 3, 2021 15:00
@Fryguy
Copy link
Member Author

Fryguy commented Aug 31, 2021

Once #215 is merged we can drop the entirety of section 4

@chessbyte
Copy link
Member

Once #215 is merged we can drop the entirety of section 4

@Fryguy #215 is merged.

@Fryguy Fryguy assigned bdunne and unassigned chessbyte Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants