Skip to content

Fix default config of manim init project to use correct pixel_height and pixel_width #4213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025

Conversation

StevenH34
Copy link
Contributor

Overview: What does this pull request change?

Fixes #4174

Motivation and Explanation: Why and how do your changes improve the library?

When creating a manim project via manim init project my-project --default the created manim.cfg file has the pixel_height and pixel_width swapped. This causes the example animations to be rendered incorrectly. I swapped the pixel_height and pixel_width back to the correct resolution.

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

@github-project-automation github-project-automation bot moved this from 🆕 New to 👍 To be merged in Dev Board Jun 23, 2025
@chopan050 chopan050 added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Jun 23, 2025
@chopan050 chopan050 changed the title Fix default config to use correct pixel_height and pixel_width Fix default config of manim init project to use correct pixel_height and pixel_width Jun 23, 2025
@chopan050 chopan050 enabled auto-merge (squash) June 23, 2025 03:16
@chopan050 chopan050 merged commit a8458cb into ManimCommunity:main Jun 23, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Default config for manim project switches pixel_height with pixel_width
2 participants