Fixed surface animations in OpenGL #4286
Open
+7
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Previously, there was an error whenever animating a
Surface
object with OpenGL. Now there is no longer!Motivation and Explanation: Why and how do your changes improve the library?
The bug occurred because the stroke and fill data of a
Surface
was not passed to the super class. This caused the conversion to an OpenGL object to create an entry in thedata
dictionary whose datatype is a float instead of the expected array.Here is a scene to recreate the bug when rendered with
--renderer=opengl
:Reviewer Checklist