Skip to content

Fix: Unsafe XML Processing Could Expose Sensitive Data in manim/mobject/svg/svg_mobject.py #4304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kira-offgrid
Copy link

Context and Purpose:

This PR automatically remediates a security vulnerability:

  • Description: The native Python xml library is vulnerable to XML External Entity (XXE) attacks. These attacks can leak confidential data and "XML bombs" can cause denial of service. Do not use this library to parse untrusted input. Instead the Python documentation recommends using defusedxml.
  • Rule ID: python.lang.security.use-defused-xml-parse.use-defused-xml-parse
  • Severity: MEDIUM
  • File: manim/mobject/svg/svg_mobject.py
  • Lines Affected: 193 - 193

This change is necessary to protect the application from potential security risks associated with this vulnerability.

Solution Implemented:

The automated remediation process has applied the necessary changes to the affected code in manim/mobject/svg/svg_mobject.py to resolve the identified issue.

Please review the changes to ensure they are correct and integrate as expected.

@behackl
Copy link
Member

behackl commented Jul 20, 2025

The status about defusedxml appears to have changed, it no longer occurs as a recommendation in the Python documentation. Moreover, the attack vector seems a bit constructed. Closing as not relevant.

@behackl behackl closed this Jul 20, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ❌ Rejected in Dev Board Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

2 participants