Skip to content

Adding type annotations to polyhedra.py and matrix.py #4322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2025
Merged

Adding type annotations to polyhedra.py and matrix.py #4322

merged 2 commits into from
Jul 20, 2025

Conversation

henrikmidtiby
Copy link
Contributor

Overview: What does this pull request change?

#3375

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Jul 1, 2025
behackl
behackl approved these changes Jul 20, 2025
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thank you very much!

@github-project-automation github-project-automation bot moved this from 🆕 New to 👍 To be merged in Dev Board Jul 20, 2025
@behackl behackl added typehints For adding/discussing typehints enhancement Additions and improvements in general labels Jul 20, 2025
@behackl behackl merged commit f124235 into ManimCommunity:main Jul 20, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Jul 20, 2025
@henrikmidtiby henrikmidtiby deleted the TypingPolyhedra branch July 21, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behackl behackl behackl approved these changes

Assignees
No one assigned
Labels
enhancement Additions and improvements in general typehints For adding/discussing typehints
Projects
Dev Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrikmidtiby @behackl