Skip to content

Commit

Permalink
Fix failing tests
Browse files Browse the repository at this point in the history
  • Loading branch information
david-yz-liu committed Sep 19, 2024
1 parent 11a4697 commit 19cee9c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion spec/controllers/groups_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
end

it 'assigns the error message to flash[:error]' do
expect(flash[:error]).to eq("Group #{group_name} already exists")
expect(flash[:error][0]).to include("Group #{group_name} already exists")
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/jobs/submissions_job_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@

it 'collects a nil revision' do
groupings.each do |g|
expect(g.reload.current_submission_used.revision_identifier).to be_nil
expect(g.reload.current_submission_used.reload.revision_identifier).to be_nil
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions spec/models/student_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@
it "should not error when given #{item[:type]} grace credits" do
Student.give_grace_credits(@student_id_list, item[:grace_credits])

expect(item[:expected]).to eql(@student1.grace_credits)
expect(item[:expected]).to eql(@student2.grace_credits)
expect(item[:expected]).to eql(@student1.reload.grace_credits)
expect(item[:expected]).to eql(@student2.reload.grace_credits)
end
end
end
Expand Down

0 comments on commit 19cee9c

Please sign in to comment.