Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renaming a group removes any associated submissions #7224

Merged
merged 9 commits into from
Oct 3, 2024

Conversation

ch-iv
Copy link
Contributor

@ch-iv ch-iv commented Sep 23, 2024

Proposed Changes

Fixes #7215, a bug where renaming a group to an existing group in a different assignment resulted in incorrect repository mapping.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) x
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Collaborator

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 11154777481

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 43 of 43 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 91.63%

Totals Coverage Status
Change from base Build 11097978703: 0.04%
Covered Lines: 40546
Relevant Lines: 43577

💛 - Coveralls

Changelog.md Outdated Show resolved Hide resolved
app/controllers/groups_controller.rb Outdated Show resolved Hide resolved
app/controllers/groups_controller.rb Outdated Show resolved Hide resolved
app/controllers/groups_controller.rb Outdated Show resolved Hide resolved
config/locales/views/groups/en.yml Outdated Show resolved Hide resolved
spec/controllers/groups_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/groups_controller_spec.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ch-iv great work! I just left one small comment.

app/models/grouping.rb Outdated Show resolved Hide resolved
@david-yz-liu david-yz-liu merged commit 1df895e into MarkUsProject:master Oct 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming a group removes any associated submissions
3 participants