Merge pull request #453 from donny-wong/v2.3.2

V2.3.2

Changelog.md

@@ -1,6 +1,10 @@
 # CHANGELOG
 All notable changes to this project will be documented here.
 
+## [v2.3.2]
+- Fix a bug in the Java tester, where failed/error tests were being detected as passing. (#451)
+- updated python-ta to 2.6.1 (#452)
+
 ## [v2.3.1]
 - Fix a bug that prevented test file from being copied from a zip file to another location on disk (#426)
 

server/autotest_server/testers/java/java_tester.py

@@ -70,15 +70,15 @@ def _parse_failure_error(self, failure, error):
         an error and failure are present, the message includes information for both.
         """
         result = {}
-        if failure and error:
+        if failure is not None and error is not None:
             failure_message = self._parse_failure_error(failure, None)["message"]
             error_message = self._parse_failure_error(None, error)["message"]
             result["status"] = "error"
             result["message"] = "\n\n".join([error_message, failure_message])
-        elif failure:
+        elif failure is not None:
             result["status"] = "failure"
             result["message"] = f'{failure.attrib.get("type", "")}: {failure.attrib.get("message", "")}'
-        elif error:
+        elif error is not None:
             result["status"] = "error"
             result["message"] = f'{error.attrib.get("type", "")}: {error.attrib.get("message", "")}'
         return result

server/autotest_server/testers/pyta/requirements.txt

@@ -1,3 +1,3 @@
 python-ta==1.4.2;python_version<"3.8"
-python-ta==2.3.2; python_version>="3.8"
+python-ta==2.6.1; python_version>="3.8"
 isort<5;python_version<"3.8"