Split arena quick-info chips and tint commander damage by attacker - #7
Open
JonathanEspinosaLong wants to merge 3 commits into
Open
Conversation
Parameterize PlayerCellQuickInfo with a QuickInfoGroup so commander-damage chips can be pinned to the top-left of the cell and counters, statuses and casts to the top-right, instead of all chips sharing one side.
Route commander-damage chips through a builder that resolves the attacking commander's theme and wraps each pill in it, so the chip takes that commander's primaryContainer with a legible onPrimaryContainer foreground.
On a commander card id change, fall back to the new card's color-identity seed right away instead of keeping the previous commander's color until the artwork-derived scheme finishes computing asynchronously. Keeps commander- tinted UI (info pills, cell backgrounds, partner borders) in sync when a commander is changed.
JonathanEspinosaLong
force-pushed
the
arena-quick-info-split
branch
from
July 8, 2026 06:42
e5e2db2 to
6eafae4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commander-damage chips now sit on the top-left of an
ArenaPlayerCellwhile counters, statuses and commander casts sit on the top-right, instead of all chips sharing one side. Each commander-damage pill is also tinted with the color of the commander that dealt the damage.Chip layout:
Commander-damage color:
primaryContainerbackground with a legibleonPrimaryContainerforeground — the same artwork-derived theme used for the cell's background and borders.Implementation:
QuickInfoGrouptoPlayerCellQuickInfoso the two groups render and pin to opposite sides, and placed two instances inPlayerCellBasicBody._CommanderDamageChip, which resolves the attacker's theme viaPlayerCardsAndThemesBuilderand wraps each pill in it.