Show life increment on the side opposite the tapped side - #8
Open
JonathanEspinosaLong wants to merge 1 commit into
Open
Show life increment on the side opposite the tapped side#8JonathanEspinosaLong wants to merge 1 commit into
JonathanEspinosaLong wants to merge 1 commit into
Conversation
Tapping the left half of an ArenaPlayerCell now shows the pending increment to the right of the life total, and tapping the right half shows it to the left. Works in both horizontal and vertical arena layouts (vertical uses the tap's horizontal position within the region).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping the left half of an
ArenaPlayerCellnow displays the pending life increment to the right of the life total, and tapping the right half displays it to the left, the increment lands opposite the side you touched.Works in both arena orientations:
Implementation:
incrementOnRightreactive toArenaPlayerController.PlayerCellSideTapsrecords the tapped side on tap-down (plumbingTapDownDetailsthroughContinuedLongPress).PlayerCellCenterorders the row viatextDirectionso the existing life-total widget is untouched.