Fix 919 #922
Draft
Fix 919 #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes - removed unused imports - sorted imports - black tidy - Encapsulated table creation and population within each TestCase Class. This removes any bleed over from other Test Classes run previously - Updated and fixed tests - heneral cleanup of unused vars and other tidy
Initial rework - all tests now chaeck against a standard set of data that will not change between tests - fixed some tests did not actually do anything (placeholders) - moved the sql query check back into the tests for readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #919
In doing so It made it obvious that the pre-populated
orm.sqlite3file was hiding several issuesThis PR is a WIP as a litmus test for fixes hilighted by this until the issues are resolved.
Included in this PR
users_queryfor easier debuggingTODO:
@josephmancuso Please have a look at this as the test failures do hilight some issues that can be easily addressed.