Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/935 for 2.0 #936

Open
wants to merge 15 commits into
base: 2.0
Choose a base branch
from

Conversation

circulon
Copy link
Contributor

@circulon circulon commented Mar 27, 2025

Addresses #935

Adds pre-commit checks for code cleanliness
implemetation:

  • Only staged files are checked
  • commit will not complete if there are ANY failures from any of these tools

Notes:

  • Black: applies changes automatically and marks them as as unstaged
  • iSort: applies changes automatically and marks them as as unstaged
  • flake8: issues are noted and require manual adjustments to code

@josephmancuso
Copy link
Member

this is ready?

@circulon
Copy link
Contributor Author

@josephmancuso

this is ready?
Yes

I have removed the ignore of imported unused imports F401 as this a cleanliness thing ;)
Also added commented out options in flake for max line length and code complexity discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants