Initial AWS modules setup #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyiliev
force-pushed
the
aws-modules-refactor
branch
from
750c1d0 to
577cfcb
Compare
bobbyiliev
commented
Jun 12, 2025
Comment on lines
+13
to
+14
| locals { | ||
| default_helm_values = { |
Collaborator
Author
There was a problem hiding this comment.
Open to suggestions if we should keep this here as it has too many cloud-specific configs, or if we should move it to the ./kubernetes dir and again make it cloud agnostic.
bobbyiliev
force-pushed
the
aws-modules-refactor
branch
from
8e9ef41 to
4927307
Compare
alex-hunt-materialize
approved these changes
Jun 17, 2025
Contributor
alex-hunt-materialize
left a comment
alex-hunt-materialize
left a comment
There was a problem hiding this comment.
Lets get this in, and we can iterate on the details in smaller PRs.
aws/modules/eks/bootstrap.sh
Outdated
| @@ -0,0 +1,37 @@ | |||
| #!/bin/bash | |||
Contributor
There was a problem hiding this comment.
Is this a duplicate of aws/modules/eks-node-group/bootstrap.sh? Is this one used?
| version = var.use_local_chart ? null : var.operator_version | ||
|
|
||
| values = [ | ||
| yamlencode(merge(local.default_helm_values, var.helm_values)) |
Contributor
There was a problem hiding this comment.
Does this do a deep merge?
|
|
||
| # Install the metrics-server for monitoring | ||
| # Required for the Materialize Console to display cluster metrics | ||
| resource "helm_release" "metrics_server" { |
Contributor
There was a problem hiding this comment.
It feels a bit weird to have this be part of the operator install, as it's a common kubernetes component that is likely to be installed for a variety of reasons.
jubrad
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving over the refactor from MaterializeInc/terraform-aws-materialize#69