Skip to content

Conversation

@jshiwamV
Copy link
Collaborator

@jshiwamV jshiwamV commented Nov 23, 2025

  • terraform destroy fails with local-exec error #102: was not able to reproduce the issue mentioned in here, @jubrad . Although I have broken down one liner command, into a set of commands to prepare kube_config file properly before getting node-claims.
  • Will raise more PRs to properly document Pre-requisites.

@jshiwamV jshiwamV requested a review from jubrad November 23, 2025 17:53
@jshiwamV jshiwamV marked this pull request as ready for review November 24, 2025 16:12
Copy link
Contributor

@alex-hunt-materialize alex-hunt-materialize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see much point in writing the file. How does this fix things?

We should document that they need kubectl, though.

kubeconfig_file=$(mktemp)
echo "$${KUBECONFIG_DATA}" > "$${kubeconfig_file}"
trap "rm -f $${kubeconfig_file}" EXIT
Copy link
Contributor

@alex-hunt-materialize alex-hunt-materialize Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This trap line should happen before the write on the line above.
The file name should also be quoted inside the trap command.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i kinda guessed if doing everything in one line is causing the issue. I will wait for @jubrad to reply, incase he knows exact steps to repro this. Otherwise i would just get rid of this file change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants