Skip to content

Conversation

@antiguru
Copy link
Member

As it says on the box, bump axum and related dependencies.

@antiguru antiguru requested review from a team as code owners October 15, 2025 15:11
@antiguru antiguru requested review from aljoscha and def- October 15, 2025 15:11
@antiguru antiguru enabled auto-merge (squash) October 15, 2025 15:11
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these issues resolved? #32429

@antiguru
Copy link
Member Author

Are these issues resolved? #32429

I think yes, as we're not including multiple axum versions anymore. I'll check again to make sure it's true what I'm saying.

Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru
Copy link
Member Author

Are these issues resolved? #32429
I think yes, as we're not including multiple axum versions anymore. I'll check again to make sure it's true what I'm saying.

Turns out I was wrong, console-subscriber pulls in old versions of axum. :(

@petrosagg
Copy link
Contributor

The problems for cloud are not related to us having multiple versions of axum in our tree, but rather that our crates expose axum types and the cloud repo uses them and expects them to be compatible with their axum dependency.

So this would be a non-issue if we also updated the cloud repo's axum to the same version but we can't because they also have some other dependencies that expect an older version and so the two sets of types can't be combined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants