Update to rand 0.9.2 #34150
Open
Update to rand 0.9.2 #34150
+204
−185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
approved these changes
Nov 16, 2025
Contributor
def-
left a comment
def-
left a comment
There was a problem hiding this comment.
No concerns from testing side
antiguru
reviewed
Nov 17, 2025
| let row = match output { | ||
| TpchView::Supplier => { | ||
| let nation = rng.gen_range(0..count_nation); | ||
| let nation = rng.random_range(0..count_nation); |
Member
There was a problem hiding this comment.
It's somewhat important that we generate the same numbers for the same seed. I'm not sure that rand has this property across versions.
If we don't guarantee this, we'd need to make sure to recreate all tpch sources to avoid negative accumulations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades us from 0.8.x to 0.9.x. A bunch of breaking changes, though mostly just renames.
rand0.9 depends ongetrandom0.3, which introduces a way to configure the randomness backend, which is useful for deterministic simulation. Unfortunately, we still also depend ongetrandom<0.3 due to transitive dependencies.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.