persist: improve ApplyMergeResult specificity #34207
Open
+60
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the move to incremental compaction we lost some specificity in the ApplyMergeResult metric since everything is applied via `perform_subset_replacement`. Instead of unconditionally returning `ApplyMergeResult::AppliedSubset` we check if the range we are replacing covers the whole batch, and if so return `AppliedExact` instead. This should return our metric fidelity to their earlier levels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the move to incremental compaction we lost some specificity in the ApplyMergeResult metric since everything is applied via
perform_subset_replacement. Instead of unconditionally returningApplyMergeResult::AppliedSubsetwe check if the range we are replacing covers the whole batch, and if so returnAppliedExactinstead. This should return our metric fidelity to their earlier levels.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.