Skip to content

ci: merge staging to master #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 16, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@
"@matrixai/events": "^4.0.0"
},
"devDependencies": {
"@matrixai/lint": "^0.2.4",
"@matrixai/lint": "^0.2.6",
"@swc/core": "1.3.82",
"@swc/jest": "^0.2.29",
"@types/jest": "^29.5.2",
4 changes: 2 additions & 2 deletions src/CreateDestroy.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Status, Class } from './types.js';
import type { Status, Class, AnyFn } from './types.js';
import { Evented } from '@matrixai/events';
import { RWLockWriter } from '@matrixai/async-locks';
import {
@@ -118,7 +118,7 @@ function ready(
} else if (descriptor.set != null) {
kind = 'set';
}
const f: Function = descriptor[kind]; // eslint-disable-line @typescript-eslint/ban-types
const f = descriptor[kind] as AnyFn;
if (typeof f !== 'function') {
throw new TypeError(`${key} is not a function`);
}
4 changes: 2 additions & 2 deletions src/CreateDestroyStartStop.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Status, Class } from './types.js';
import type { Status, Class, AnyFn } from './types.js';
import { Evented } from '@matrixai/events';
import { RWLockWriter } from '@matrixai/async-locks';
import {
@@ -238,7 +238,7 @@ function ready(
} else if (descriptor.set != null) {
kind = 'set';
}
const f: Function = descriptor[kind]; // eslint-disable-line @typescript-eslint/ban-types
const f = descriptor[kind] as AnyFn;
if (typeof f !== 'function') {
throw new TypeError(`${key} is not a function`);
}
3 changes: 2 additions & 1 deletion src/StartStop.ts
Original file line number Diff line number Diff line change
@@ -159,7 +159,8 @@ function ready(
} else if (descriptor.set != null) {
kind = 'set';
}
const f: Function = descriptor[kind]; // eslint-disable-line @typescript-eslint/ban-types
type AnyFn = (...args: Array<unknown>) => unknown;
const f = descriptor[kind] as AnyFn;
if (typeof f !== 'function') {
throw new TypeError(`${key} is not a function`);
}
4 changes: 3 additions & 1 deletion src/types.ts
Original file line number Diff line number Diff line change
@@ -11,4 +11,6 @@ type Status = 'destroying' | 'starting' | 'stopping' | null;

type Class<T> = new (...args: any[]) => T;

export type { PromiseDeconstructed, Status, Class };
type AnyFn = (...args: Array<unknown>) => unknown;

export type { PromiseDeconstructed, Status, Class, AnyFn };
5 changes: 2 additions & 3 deletions src/utils.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { PromiseDeconstructed } from './types.js';
import type { AnyFn, PromiseDeconstructed } from './types.js';

/**
* Symbols prevents name clashes with decorated classes
@@ -42,8 +42,7 @@ function promise<T = void>(): PromiseDeconstructed<T> {
* This function rewrites the stack trace according to where the wrapped
* function is called, giving a more useful stack trace
*/
// eslint-disable-next-line @typescript-eslint/ban-types
function resetStackTrace(error: Error, decorated?: Function): void {
function resetStackTrace(error: Error, decorated?: AnyFn): void {
if (error.stack != null) {
const stackTitle = error.stack.slice(0, error.stack.indexOf('\n') + 1);
if (hasCaptureStackTrace) {
2 changes: 1 addition & 1 deletion tests/CreateDestroy.test.ts
Original file line number Diff line number Diff line change
@@ -377,7 +377,7 @@ describe('CreateDestroy', () => {
(async () => {
const x = new X();
const destroy = x.destroy();
x.a;
void x.a;
await destroy;
})(),
).resolves.toBeUndefined();
4 changes: 2 additions & 2 deletions tests/CreateDestroyStartStop.test.ts
Original file line number Diff line number Diff line change
@@ -596,7 +596,7 @@ describe('CreateDestroyStartStop', () => {
await expect(
(async () => {
const start = x.start();
x.a;
void x.a;
await start;
})(),
).rejects.toThrow(ErrorAsyncInitNotRunning);
@@ -614,7 +614,7 @@ describe('CreateDestroyStartStop', () => {
await expect(
(async () => {
const stop = x.stop();
x.a;
void x.a;
await stop;
})(),
).resolves.toBeUndefined();
4 changes: 2 additions & 2 deletions tests/StartStop.test.ts
Original file line number Diff line number Diff line change
@@ -311,7 +311,7 @@ describe('StartStop', () => {
await expect(
(async () => {
const start = x.start();
x.a;
void x.a;
await start;
})(),
).rejects.toThrow(ErrorAsyncInitNotRunning);
@@ -329,7 +329,7 @@ describe('StartStop', () => {
await expect(
(async () => {
const stop = x.stop();
x.a;
void x.a;
await stop;
})(),
).resolves.toBeUndefined();