-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SwiftPM 5.3 support with resource bundle and watchOS support #294
base: master
Are you sure you want to change the base?
Conversation
Would it be possible to support watchOS as well? We are using DateTools on watchOS today, but with Cocoapods. We are planning to migrate to SPM in the future. |
@pontusm Not much familiar with limitations of WatchOS, but can definitely look into it and enable it as part of this PR. I'm planning to clean it up and make the final version of it this week. I'll merge it into |
That would be great! As I mentioned, we already use it on watchOS so I don't think you have to do much to support it. Probably just need to add it to the "platforms" list in the package file. |
b5f0129
to
7e67b02
Compare
7e67b02
to
b7f0415
Compare
@pontusm It's ready for being merge into the main branch. I'm going to merge it into my fork, so feel free to use that. |
tried and getting error |
ok figured out, long ago i was using cartage on the project and not all OTHER_LDFLAGS was removed |
Any update on this? |
It is merged in my fork. Feel free to use that or fork from mine. I've only added SPM support and fixed some tests, no other changes are in this fork. |
This is currently WIP due to Swift 5.3 being in beta. This CR includes the work for fixing the unit tests in addition to prevent app crashing due to unavailability of the bundle. This is based on the #291 PR, but if that branch deosn't get merged in by the time Xcode 12 / Swift 5.3 is released, this can be cleaned up and used instead and the other PR should be disregarded.