Use UTC for application assignment deadlines#63
Open
chryzsh wants to merge 1 commit intoMayyhem:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was playing with EXEC-1 in my lab and had some issues getting applications to fire. I found the code was using
DateTime.Nowwhile also settingUseGMTTimes = true, which would make SCCM treat the deadline as being in the future if the operator machine with a different timezone from the SCCM environment. I guess this is likely very rarely an issue, but it happened in my lab so maybe this could happen if you are ever operating across timezones or have forgot to set the system time on either side.This changes the timestamp to
DateTime.UtcNowwith+000so the start time and enforcement deadline are always written as real UTC values which would be relative on the operator computer and the target client.Type of Change
Testing
execflow after the change.SharpSCCM_merged.exe exec -p "cmd.exe /c whoami > C:\temp\usertest.txt" -d client --no-banner -sms mecm -sc p01Test Configuration:
.\SharpSCCM.exe get class-instances SMS_Site -p Version): Version: 5.00.9128.1000.\SharpSCCM.exe local class-instances SMS_Client): ClientVersion: 5.00.9128.1007Bonus Points:
https://github.com/Mayyhem/SharpSCCM/blob/main/Properties/AssemblyInfo.cs