Support building and installing helper executables when cross-compiling #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMAKE_CONFIGURATION_TYPES is defined by CMake when executing the project() command while using a multi-config generator like Visual Studio or Xcode. Thus `NOT DEFINED CMAKE_CONFIGURATION_TYPES` was always evaluate to false.
Especially for paths that contain spaces.
This could have been done in f64dff5
try_compile() should be used for testing whether a project can be built with the current CMake toolchain, not for building and installing arbitrary software. This change is required to support cross-compiling toolchains like iOS and Android, since we need to build the helper executables for the host and not the target platform.
This was not done in the previous commit to reduce its diff.
McMartin
force-pushed
the
build-and-install-helpers-when-cross-compiling
branch
from
c39ccb2 to
07bc5c0
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to support iOS (see #551 (comment)).
@MartyLake: please review, thanks!