fix: support SVG icons for applications - MEED-10330 - Meeds-io/meeds#4045 #578
Merged
fix: support SVG icons for applications - MEED-10330 - Meeds-io/meeds#4045 #578
Conversation
…#4045 (#577) Prior to this change, SVG images added as icons to applications were not displayed after saving. This happened because the application illustration URL was hardcoded to use a PNG MIME type, which does not work for vector images like SVG. Root Cause: - The uploaded SVG icon was correctly shown in the edit drawer, but after saving, the system reused a hardcoded PNG MIME type for the illustration URL. - This caused SVG icons to break, since they are not bitmap images. Fix: - Store the correct MIME type from FileInfo when uploading the icon. - Reuse the stored MIME type when generating the illustration URL, ensuring SVG icons are correctly displayed in saved applications.
|
azayati
approved these changes
Mar 30, 2026
exo-swf
pushed a commit
that referenced
this pull request
Mar 30, 2026
…#4045 (#578) Prior to this change, SVG images added as icons to applications were not displayed after saving. This happened because the application illustration URL was hardcoded to use a PNG MIME type, which does not work for vector images like SVG. Root Cause: - The uploaded SVG icon was correctly shown in the edit drawer, but after saving, the system reused a hardcoded PNG MIME type for the illustration URL. - This caused SVG icons to break, since they are not bitmap images. Fix: - Store the correct MIME type from FileInfo when uploading the icon. - Reuse the stored MIME type when generating the illustration URL, ensuring SVG icons are correctly displayed in saved applications. fixes Meeds-io/meeds#4045
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, SVG images added as icons to applications were not displayed after saving. This happened because the application illustration URL was hardcoded to use a PNG MIME type, which does not work for vector images like SVG.
Root Cause:
Fix:
fixes Meeds-io/meeds#4045