Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add meta information for HTML pages #396

Merged
merged 1 commit into from
Mar 31, 2022
Merged

feat: add meta information for HTML pages #396

merged 1 commit into from
Mar 31, 2022

Conversation

cheekyshibe
Copy link
Contributor

@cheekyshibe cheekyshibe commented Mar 29, 2022 •
edited
Loading

This is an example commit. @jiaochenlu 举一反三的时间到了。

image

注意事项：

  • Keyword 中间用英文逗号 + 空格隔开（哪怕是中文内容）
  • 务必带上 lang 标签，中文用 zh-Hans, 英文用 en

无法通过 Review 的案例

  1. 没有严格区分中英双语的 lang 属性；
  2. Keyword 与页面内容无关；
  3. Description 简单拷贝原文开头内容，没起到全文描述的效果。

Refs:

@gitpod-io
Copy link

gitpod-io bot commented Mar 29, 2022

@cheekyshibe cheekyshibe requested a review from xxr3376 March 29, 2022 10:40
@cheekyshibe cheekyshibe added the enhancement New feature or request label Mar 29, 2022
@xxr3376
Copy link
Member

xxr3376 commented Mar 29, 2022

LGTM

@cheekyshibe cheekyshibe marked this pull request as ready for review March 31, 2022 08:24
@cheekyshibe cheekyshibe merged commit c1e42a9 into main Mar 31, 2022
@cheekyshibe cheekyshibe deleted the html-meta branch March 31, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxr3376 xxr3376 Awaiting requested review from xxr3376

Assignees

@cheekyshibe cheekyshibe

@jiaochenlu jiaochenlu

@HuaHua404 HuaHua404

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cheekyshibe @xxr3376 @jiaochenlu @HuaHua404