lwip/tcp.c: remove unused and duplicated code #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
tcp_abandon() calls tcp_pcb_remove() which calls tcp_pcb_purge(). Since we can abandon only non LISTEN sockets, all segments lists are guaranteed to be empty after tcp_pcb_remove(). Checking them is an extra code. external_ip_output() is not used anywhere and the code around this function is dead. Signed-off-by: Dmytro Podgornyi <[email protected]>
|
Test PASSed. |
snd_wnd and ssthresh are reassigned later unconditionally. Also, fix coding style of the code. Signed-off-by: Dmytro Podgornyi <[email protected]>
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tcp_abandon() calls tcp_pcb_remove() which calls tcp_pcb_purge(). Since
we can abandon only non LISTEN sockets, all segments lists are
guaranteed to be empty after tcp_pcb_remove(). Checking them is an
extra code.
external_ip_output() is not used anywhere and the code around this
function is dead.