Decode bytes before running string operations on the same#85
Open
rohit-mundra wants to merge 2 commits into
Open
Decode bytes before running string operations on the same#85rohit-mundra wants to merge 2 commits into
rohit-mundra wants to merge 2 commits into
Conversation
ntnx-alay
approved these changes
Mar 5, 2024
ntnx-alay
left a comment
There was a problem hiding this comment.
Looks good to me. This would uncover in certain conditions where vlan is enabled. Otherwise code path is not exercised.
prasheshpatel
approved these changes
Mar 5, 2024
prasheshpatel
left a comment
There was a problem hiding this comment.
The code change resolves #84 impacting Socket Priority to User Priority mapping for a parent PF device of the VLAN device.
c71b0d1 to
fb4c658
Compare
Collaborator
|
When removing spaces, you also removed useful spaces. Please fix that. |
Author
Not able to find which space I have removed, as I have added just the decode calls to line variable. [rohit.mundra@rohit-mundra mlnx-tools]$ git diff HEAD~2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post execution of grep on vlan information for interface and when tc tool is executed get qdisc information for the device, the bytes must be converted to string to run split and regex.
resolve: #84