Skip to content

fix(scheduler): report total working memory count in log_working_memory_replacement - #2636

Merged
endxxxx merged 3 commits into
dev-v2.0.37from
codex/maintainer-edit-pr-1795-20261119
Nov 20, 2026
Merged

endxxxx merged 3 commits into
dev-v2.0.37from
codex/maintainer-edit-pr-1795-20261119

Conversation

@syzsunshine219

Copy link
Copy Markdown
Collaborator

The source branch for the change proposed in #1795 now lives in MemTensor/MemOS, so repository writers can contribute fixes through the normal upstream branch permissions.

The code and commit authors are unchanged. This PR retains target branch main and exact source head b7013d0cc5291dabd330f8c773f37fb7db378954 from #1795.

Previous discussion and review remain in #1795. Review and checks must be re-evaluated for this replacement PR; no previous approval or new test result is asserted by this migration.

Previous PR description and implementation details

Description

log_working_memory_replacement was passing memory_len=len(memcube_content) where memcube_content only contains newly added memories. This caused the scheduler UI to show the delta count instead of the total working memory size after replacement.

Fix: use len(new_memory) to report the actual output count.

Related Issue (Required): Fixes #1790

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

  • Unit Test

Checklist

  • I have performed a self-review of my own code | 我已自行检查了自己的代码
  • I have commented my code in hard-to-understand areas | 我已在难以理解的地方对代码进行了注释
  • I have added tests that prove my fix is effective or that my feature works | 我已添加测试以证明我的修复有效或功能正常
  • I have created related documentation issue/PR in MemOS-Docs (if applicable) | 我已在 MemOS-Docs 中创建了相关的文档 issue/PR(如果适用)
  • I have linked the issue to this PR (if applicable) | 我已将 issue 链接到此 PR(如果适用)
  • I have mentioned the person who will review this PR | 我已提及将审查此 PR 的人

@syzsunshine219 syzsunshine219 added the area:scheduler 调度模块 label Nov 19, 2026
@Memtensor-AI Memtensor-AI added the status:in-progress Someone or AI is working on it | 人工或 AI 正在处理 label Nov 19, 2026
@Memtensor-AI
Memtensor-AI requested a review from wustzdy November 19, 2026 14:59
@Memtensor-AI

Memtensor-AI commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 Open Code Review

Target: PR #2636
Task: 356ca5a66f22c362
Base: dev-v2.0.37
Head: codex/maintainer-edit-pr-1795-20261119
Head SHA: cf777008fc271148f4f5d3689161bc335e7ef865

✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s).

Generated by cloud-assistant via Open Code Review.

@endxxxx
endxxxx changed the base branch from main to dev-v2.0.37 November 20, 2026 06:37
@Memtensor-AI Memtensor-AI added status:ready Ready for implementation; waiting for assignee or AI dispatch | 可进入实现,等待认领或派发 and removed status:in-progress Someone or AI is working on it | 人工或 AI 正在处理 labels Nov 20, 2026
@endxxxx
endxxxx merged commit bcb33d1 into dev-v2.0.37 Nov 20, 2026
17 checks passed
@endxxxx
endxxxx deleted the codex/maintainer-edit-pr-1795-20261119 branch November 20, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:scheduler 调度模块 status:ready Ready for implementation; waiting for assignee or AI dispatch | 可进入实现,等待认领或派发

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: log_working_memory_replacement reports incorrect memory_len (delta instead of total)

7 participants