Repository navigation
fix(scheduler): report total working memory count in log_working_memory_replacement - #2636
Merged
Merged
Conversation
Collaborator
🤖 Open Code ReviewTarget: PR #2636 ✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). Generated by cloud-assistant via Open Code Review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source branch for the change proposed in #1795 now lives in
MemTensor/MemOS, so repository writers can contribute fixes through the normal upstream branch permissions.The code and commit authors are unchanged. This PR retains target branch
mainand exact source headb7013d0cc5291dabd330f8c773f37fb7db378954from #1795.Previous discussion and review remain in #1795. Review and checks must be re-evaluated for this replacement PR; no previous approval or new test result is asserted by this migration.
Previous PR description and implementation details
Description
log_working_memory_replacementwas passingmemory_len=len(memcube_content)wherememcube_contentonly contains newly added memories. This caused the scheduler UI to show the delta count instead of the total working memory size after replacement.Fix: use
len(new_memory)to report the actual output count.Related Issue (Required): Fixes #1790
Type of change
How Has This Been Tested?
Checklist