fix(windows desktop failure start): keep the app alive when the startup splash times out before boot finishes - #493
Closed
xuzhiqin1990 wants to merge 1 commit into
Conversation
…fore boot finishes The startup splash is a BrowserWindow with a 15 s auto-close timer. When the managed runtime (migrations, Memory service, agent gateway) takes longer than that to start, the splash closes while the main window does not exist yet, so window-all-closed fires mid-boot and the Windows/Linux handler calls app.quit(). The app exits with code 0 and no error: the user sees "Memmy is starting..." and then nothing. A dev cold start measured 47 s on Windows, so this happened on most cold launches; packaged startup.log also shows boot:start entries with no boot:ready. window-all-closed now ignores closes that happen before boot has created the main window (shouldQuitWhenAllWindowsClosed). Boot failures already quit explicitly, so a failed boot still exits. macOS keeps its never-quit behavior. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
|
This issue has been fixed and will be released with version v1.1.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The startup splash is a BrowserWindow with a 15 s auto-close timer. When the managed runtime (migrations, Memory service, agent gateway) takes longer than that to start, the splash closes while the main window does not exist yet, so window-all-closed fires mid-boot and the Windows/Linux handler calls app.quit(). The app exits with code 0 and no error: the user sees "Memmy is starting..." and then nothing. A dev cold start measured 47 s on Windows, so this happened on most cold launches; packaged startup.log also shows boot:start entries with no boot:ready.
window-all-closed now ignores closes that happen before boot has created the main window (shouldQuitWhenAllWindowsClosed). Boot failures already quit explicitly, so a failed boot still exits. macOS keeps its never-quit behavior.