Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New generic rare golden emote modifier with a 1.5% proc chance thats deactivated during halloween #129

Merged
merged 6 commits into from
Nov 8, 2019

Conversation

x-Xymos
Copy link
Contributor

@x-Xymos x-Xymos commented Oct 8, 2019

@jbpratt jbpratt requested review from jbpratt and kenany October 9, 2019 00:20
@Oreganon
Copy link
Contributor

Oreganon commented Oct 9, 2019

Way to common in my opinion. I think it should be truly rare with about one occurrence per day.

There were 277840 emotes used in september, thats about 9000 emotes per day. So I suggest 1 / 9000 = 0.00011111111 as the probability.

@x-Xymos
Copy link
Contributor Author

x-Xymos commented Oct 9, 2019

Way to common in my opinion. I think it should be truly rare with about one occurrence per day.

There were 277840 emotes used in september, thats about 9000 emotes per day. So I suggest 1 / 9000 = 0.00011111111 as the probability.

1 a day sounds kind of low, why not something like 10-20 a day, what does everyone else think.

@jbpratt
Copy link
Member

jbpratt commented Oct 9, 2019

I like the idea of it being incredibly rare, even more so than a 'once a day' chance. Would love to hear others thoughts, maybe even poll a few members of the community.

@Oreganon
Copy link
Contributor

Oreganon commented Oct 9, 2019

Now that I think about it, once per day would get boring very soon I think. It would be too common so you would get used to it and it would lose it special appeal. Maybe even once per month would be nice.

@SoMuchForSubtlety
Copy link
Collaborator

Once a month still seems very high, how about once a decade?

@SmCTwelve
Copy link
Contributor

Correlate the probability with how often Dashh appears in chat.

@x-Xymos
Copy link
Contributor Author

x-Xymos commented Oct 9, 2019

It's turned off for halloween anyway so we have time to gather votes from chat before we decide to merge https://www.strawpoll.me/18764578/r

@jbpratt jbpratt requested review from SoMuchForSubtlety and removed request for kenany November 8, 2019 21:14
@jbpratt jbpratt merged commit 3bf91cb into MemeLabs:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants