feat: Soroban contract — initialize, platform fee, treasury, dispute window#820
Merged
nafiuishaaq merged 4 commits intoJun 24, 2026
Merged
Conversation
Implements Soroban smart contract covering: - initialize(admin, treasury): one-time setup with Initialized event (MentoNest#748) - set/get_platform_fee (0-1000 bps), PlatformFeeUpdated event (MentoNest#749) - set/get_treasury (admin-only), TreasuryUpdated event (MentoNest#750) - set/get_dispute_window (default 1000 ledgers), DisputeWindowUpdated event (MentoNest#751) All functions use persistent storage and admin-only access control. Includes unit tests and GitHub Actions CI workflow. Closes MentoNest#748 Closes MentoNest#749 Closes MentoNest#750 Closes MentoNest#751
|
@Userhorlie Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the core Soroban smart contract for SkillSync, covering issues #748–#751.
Changes
contract/Cargo.tomlcdylibfor WASM compilationsoroban-sdk 22.0.0withallocfeaturetestutilsfor unit testscontract/src/lib.rsinitialize(admin, treasury)— one-time only, emitsInitializedset_platform_fee(bps),get_platform_fee()— 0–1000 bps, emitsPlatformFeeUpdatedset_treasury(address),get_treasury()— admin-only, emitsTreasuryUpdatedset_dispute_window(ledgers),get_dispute_window()— default 1000, emitsDisputeWindowUpdatedAll setter functions are admin-only via
require_auth(). All state stored in persistent storage..github/workflows/contract.ymlcontract/**Tests
6 unit tests covering initialization, re-init guard, fee validation, treasury update, and dispute window update.
Closes #748
Closes #749
Closes #750
Closes #751