[codex] Fix Mentra Live action button event id#3105
Draft
PhilippeFerreiraDeSousa wants to merge 1 commit into
Draft
[codex] Fix Mentra Live action button event id#3105PhilippeFerreiraDeSousa wants to merge 1 commit into
PhilippeFerreiraDeSousa wants to merge 1 commit into
Conversation
📋 PR Review Helper📱 Mobile App Build✅ Ready to test! (commit 🕶️ ASG Client Build❌ Build failed (commit 📦 Previous build: (commit 🔀 Test Locallygh pr checkout 3105 |
ba95545 to
56ea332
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the public Mentra Live button identifier so the right action button is surfaced as
buttonId: "action"instead of the stale camera-button label.Event-name mapping
type: "button_press",buttonId: "action", `pressType: "short"button_presswithButtonPressEvent.buttonId === "action"on Mentra Live"camera"IDs to"action"before emitting to the public SDK bridge.StreamType.BUTTON_PRESS/"button_press"with opaquebuttonId; Mentra Live documented as"action"touch_eventgesture names such assingle_tap,double_tap,forward_swipe, etc.Scope
buttonId: "camera"tobuttonId: "action"."camera"still surface as"action"to public SDK consumers.Compatibility notes
This intentionally changes the public Mentra Live button identifier from
"camera"to"action". The Bluetooth SDK parser compatibility path maps older glasses payloads from"camera"to"action", so apps using current SDK builds will see the corrected identifier even before all glasses-side clients are updated.Validation
git diff --checkcd asg_client && ./gradlew :app:compileDebugJavaWithJavacMobile/cloud
node_moduleswere not installed in the wrapper worktree, and the TypeScript changes are comments/docs only. The Bluetooth SDK native parser edits were statically inspected.