Fast-fail local photo receiver uploads#3110
Draft
PhilippeFerreiraDeSousa wants to merge 1 commit into
Draft
Conversation
📋 PR Review Helper📱 Mobile App Build✅ Ready to test! (commit 🕶️ ASG Client Build❌ Build failed (commit 🔀 Test Locallygh pr checkout 3110 |
Contributor
Author
|
We want this fail fast regardless of whether the web hook url is local or in the cloud |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/24as the glasses Wi-Fi IP, when the Android photo receiver publishes its upload URL.Root Cause
Live logs showed the photo receiver and stream receiver were both advertising the phone LAN address
192.168.50.176, while the glasses were on192.168.50.43. The photo path sent:The photo then fell back through BLE:
After app restart, stream failed with the same destination:
Direct reachability checks confirmed both devices were on
192.168.50.0/24, but the glasses could not reach the phone:So the current field failure is not photo-specific. The LAN path is unreachable for both photo upload and WHIP streaming. This PR does not pretend to fix an isolated/AP-client-isolation network; it makes the photo path choose a better receiver address when multiple interfaces exist and avoid the avoidable 5s wait before BLE fallback for local receiver URLs that cannot be reached.
Validation
git diff --checkcd asg_client && ./gradlew :app:compileDebugJavaWithJavaccd mobile/modules/bluetooth-sdk && bun run buildcd asg_client && ANDROID_SERIAL=0123456789ABCDEF ./gradlew :app:installDebugRFCX71TH0CRand glasses0123456789ABCDEFcd mobile && bun compilewas also run after dependency install, but it is currently blocked by unrelated existing TypeScript errors insrc/services/asg/gallerySyncService.test.tsat theresolveConnectivity?.()calls.