Improve Mentra Live pairing UX (OS-1615)#3224
Open
nic-olo wants to merge 27 commits into
Open
Conversation
nic-olo
requested review from
AryanFP,
PhilippeFerreiraDeSousa and
aisraelov
as code owners
Deploying mentra-store-dev with
|
| Latest commit: |
2f3dbe9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://431f7636.augmentos-appstore-2.pages.dev |
| Branch Preview URL: | https://nicolo-os-1615-improve-mentr.augmentos-appstore-2.pages.dev |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Deploying dev-augmentos-console with
|
| Latest commit: |
2f3dbe9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d606a63.dev-augmentos-console.pages.dev |
| Branch Preview URL: | https://nicolo-os-1615-improve-mentr.dev-augmentos-console.pages.dev |
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Deploying prod-augmentos-account with
|
| Latest commit: |
2f3dbe9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://00a08dba.augmentos-e84.pages.dev |
| Branch Preview URL: | https://nicolo-os-1615-improve-mentr.augmentos-e84.pages.dev |
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Deploying mentra-live-ota-site with
|
| Latest commit: |
2f3dbe9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://754ba77b.mentra-live-ota-site.pages.dev |
| Branch Preview URL: | https://nicolo-os-1615-improve-mentr.mentra-live-ota-site.pages.dev |
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…roid Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
nic-olo
force-pushed
the
nicolo/os-1615-improve-mentra-live-pairing-ux
branch
from
9653e98 to
2f3dbe9
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2f3dbe9. Configure here.
| return | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Missing finalize on first pair
High Severity
When pairing_info reports no prior bond, the loading screen marks pairing resolved and navigates to success without calling BluetoothSdk.finalizePairingTransfer(). The ownership-transfer design expects finalize on every successful new bond; only the wipe path sends it today.
Reviewed by Cursor Bugbot for commit 2f3dbe9. Configure here.
| val isReconnectTarget = | ||
| savedDeviceName != null && savedDeviceName == deviceName | ||
| if (!isReconnectTarget && !isPairingDiscoverable(result)) { | ||
| return |
There was a problem hiding this comment.
Stale name bypasses pairing filter
High Severity
The new scan filter skips the pairing-mode advertisement check when the discovered name matches a saved reconnect target. That saved name is not cleared on forget() (Android in-memory savedDeviceName, iOS UserDefaults), so pairing scan can surface and auto-connect to glasses that are not in pairing mode.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 2f3dbe9. Configure here.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pairing_info,wipe_media_result, and pairing transfer commands.wipe_mediahandler on asg_client to erase gallery during ownership transfer.Test plan
connectDefault()without scan list.Made with Cursor