Skip to content

Fixes 56#3234

Open
fossephate wants to merge 7 commits into
devfrom
fixes-56
Open

Fixes 56#3234
fossephate wants to merge 7 commits into
devfrom
fixes-56

Conversation

@fossephate

@fossephate fossephate commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Mic recovery and DeviceStore semantics touch core G2 session/audio behavior on both platforms; calendar sync changes what gets persisted in JS before native push.

Overview
G2 (Android/iOS) splits mic user intent (evenHubMicIntent) from glasses/micEnabled hardware state in DeviceStore. Page/dashboard shutdown and firmware exits now set state off without clearing intent, so recoverPageAndMic and restartMic can re-arm the mic after rebuilds instead of treating stale “on” flags as healthy. Connect auth also sends time sync to both lenses (left + right).

Mobile app: sendCalendarEvents updates the in-memory settings store before pushing to the glasses so a later bulk Bluetooth settings read does not wipe events with an empty default; events include startDate and the method is public. Local miniapp runtime copies native gestureName into kind on touch events so per-gesture streams and SDK handlers align.

Reviewed by Cursor Bugbot for commit ffdea31. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

📋 PR Review Helper

📱 Mobile App Build

Build failed (commit ffdea31) - View logs

📦 Previous build: (commit f9c467e) - 📥 Download APK

🕶️ ASG Client Build

Waiting for build...


🔀 Test Locally

gh pr checkout 3234

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

PR Agent Orchestrator State

{
  "cycle": 3,
  "fixRound": 0,
  "totalReviewerRuns": 3,
  "consecutiveNoNewReviews": 3,
  "openFindings": [],
  "resolvedFindings": [],
  "nitFindings": [],
  "phase": "discovery",
  "status": "in_progress",
  "lastPair": [],
  "stagnationFixRounds": 0,
  "lastOpenCount": 0,
  "fingerprintReopenCounts": {},
  "mutedFingerprints": []
}

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

🤖 PR Agent Review — cycle 3

✅ No blocking findings · 0 blocking · 0 nits
Reviewers this cycle: none

No model reviews ran this cycle.

Updated automatically by the PR Agent Orchestrator each review cycle. Nits do not block merge.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ffdea31. Configure here.

pageCreated = false
evenHubMicActive = false // firmware killed the mic with the page
// firmware killed the mic with the page -> STATE off (intent preserved)
DeviceStore.apply("glasses", "micEnabled", false)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mic watchdog ignores user intent

High Severity

G2 now writes hardware mic state to glasses/micEnabled and clears it whenever the EvenHub page dies, while user intent lives in evenHubMicIntent. checkAndReinitGlassesMic still gates on glasses/micEnabled, so after a firmware page kill with mic intent still on, the 5s LC3 watchdog exits early and never calls setMicEnabled(true).

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ffdea31. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants