Point production OTA clients to v2 manifest#3244
Point production OTA clients to v2 manifest#3244PhilippeFerreiraDeSousa wants to merge 5 commits into
Conversation
📋 PR Review Helper📱 Mobile App Build✅ Ready to test! (commit 🕶️ ASG Client Build✅ Ready to test! (commit 🔀 Test Locallygh pr checkout 3244 |
Deploying mentra-live-ota-site with
|
| Latest commit: |
90874dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2e942f9f.mentra-live-ota-site.pages.dev |
| Branch Preview URL: | https://codex-dev-ota-v2-url.mentra-live-ota-site.pages.dev |
|
Exciting! |
PR Agent Orchestrator State{
"cycle": 2,
"fixRound": 0,
"totalReviewerRuns": 2,
"consecutiveNoNewReviews": 2,
"openFindings": [],
"resolvedFindings": [],
"nitFindings": [],
"phase": "discovery",
"status": "in_progress",
"lastPair": [],
"stagnationFixRounds": 0,
"lastOpenCount": 0,
"fingerprintReopenCounts": {},
"mutedFingerprints": []
} |
🤖 PR Agent Review — cycle 2✅ No blocking findings · 0 blocking · 0 nits No model reviews ran this cycle. Updated automatically by the PR Agent Orchestrator each review cycle. Nits do not block merge. |
|
why are you removing the recovery worker? It has not impact on the OTA |
|
"Remove the unused standalone asg_client/ota_updater project; live ASG compatibility cleanup for already-installed com.augmentos.otaupdater packages is intentionally left in place." This is wrong no production mentra live has com.augmentos.otaupdater installed |
|
The rest of the changes LGTM |
This reverts commit aa182fd.
So why is it in the prod OTA manifests? https://ota.mentraglass.com/prod_live_version.json |
|
@PhilippeFerreiraDeSousa Long ago we planned to have a separate dedicated ota updater app. We decided not to do it- too much complication and the (assumed) benefits turned out to be not true. It being in the manifest is just something we never deleted. |
# Conflicts: # mobile/src/services/asg/asgOtaVersionUrl.ts
Deploying mentra-store-dev with
|
| Latest commit: |
90874dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://60e31d85.augmentos-appstore-2.pages.dev |
| Branch Preview URL: | https://codex-dev-ota-v2-url.augmentos-appstore-2.pages.dev |
Deploying dev-augmentos-console with
|
| Latest commit: |
90874dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bf1080d5.dev-augmentos-console.pages.dev |
| Branch Preview URL: | https://codex-dev-ota-v2-url.dev-augmentos-console.pages.dev |
Deploying prod-augmentos-account with
|
| Latest commit: |
90874dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22a1eb5a.augmentos-e84.pages.dev |
| Branch Preview URL: | https://codex-dev-ota-v2-url.augmentos-e84.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90874dd276
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Keep prod as the legacy-device fallback for SDK checks. Pre-override ASG | ||
| // builds ignore ota_start.ota_version_url and use their compiled rescue | ||
| // manifest, then continue future updates on v2 after the rescue update. | ||
| const val PROD_OTA_VERSION_URL = "https://ota.mentraglass.com/prod_live_version_v2.json" |
There was a problem hiding this comment.
When a pre-39 ASG build still advertises the old production URL, this new fallback constant is bypassed: MentraBluetoothSdk.resolveOtaVersionUrl() returns status.otaVersionUrl whenever it is nonblank before consulting OtaManifestDefaults.PROD_OTA_VERSION_URL (and the Swift resolver has the same branch). That means SDK checkForOtaUpdate() remains pinned to prod_live_version.json for the legacy devices this migration is meant to rescue, so any ASG/firmware update published only on prod_live_version_v2.json will never be offered to SDK apps. The legacy resolver should force v2 or rewrite the old prod URL rather than only changing the blank-URL fallback.
Useful? React with 👍 / 👎.
4 participants
Summary
https://ota.mentraglass.com/prod_live_version_v2.json.asg_client/ota_website/prod_live_version_v2.jsonas the forward production manifest path, based on the current dev production manifest without the legacycom.augmentos.otaupdaterapp entry.Why
The original production manifest must remain available as the legacy rescue path for older ASG clients that may be stuck on corrupted artifact cache state and ignore
ota_start.ota_version_url. New MentraOS and SDK checks should look at the v2 manifest, which can advance beyond the rescue manifest. If old glasses need an update,ota_startwill still use their compiled rescue manifest first; once the upgraded ASG client is installed, follow-up checks continue on v2.Validation
git diff --check origin/dev...HEADjq empty asg_client/ota_website/prod_live_version.json asg_client/ota_website/prod_live_version_v2.jsonrg "https://ota\.mentraglass\.com/prod_live_version\.json|prod_live_version\.json" . -g '!**/build/**' -g '!**/node_modules/**' -g '!**/.git/**'returns no matchescd asg_client && ./gradlew :app:compileDebugJavaWithJavaccd mobile && bun install && bun compilecd mobile && ../scripts/check-android-compile.sh bluetooth-sdkSwiftPM note:
cd mobile/modules/bluetooth-sdk && swift buildis blocked locally byDeviceManager.swiftimportingUIKitwith this toolchain (no such module 'UIKit') before this URL-only change is exercised.Note
High Risk
Changes which OTA manifest production glasses and apps use; misrouting could show wrong updates or block rescue paths, though legacy builds are explicitly pinned to the old manifest.
Overview
Production OTA defaults now use
prod_live_version_v2.jsoninstead ofprod_live_version.json, while the original manifest stays in place as the legacy rescue channel for ASG builds that ignore phone-suppliedota_start.ota_version_url.ASG-side compiled defaults (
OtaConstants, OTA updater, recovery worker) andrestore-stock.shfetch v2. A newasg_client/ota_website/prod_live_version_v2.jsonis the forward production manifest (no legacycom.augmentos.otaupdaterapp entry).MentraOS mobile sets production checks to v2 via
OTA_VERSION_URL_PRODand addsOTA_VERSION_URL_LEGACY_PROD. For glasses build < 39,getAsgOtaVersionUrlalways uses the legacy manifest so availability checks match what those devices actually install from.Bluetooth SDK (Android/iOS) mirrors that rule: legacy builds resolve OTA checks to
LEGACY_PROD_OTA_VERSION_URLinstead of the glasses-advertised URL or the v2 default.Reviewed by Cursor Bugbot for commit 994c434. Bugbot is set up for automated code reviews on this repo. Configure here.