Scale keep_alive TTL bumps to match each contract's real lifecycle - #233
Open
avqor wants to merge 2 commits into
Open
Scale keep_alive TTL bumps to match each contract's real lifecycle#233avqor wants to merge 2 commits into
avqor wants to merge 2 commits into
Conversation
|
@avqor is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
avqor
force-pushed
the
fix/ttl-extension-thresholds
branch
from
August 30, 2026 19:17
05bcee5 to
b512ed8
Compare
|
@avqor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
escrow's keep_alive/extend_deadline already scale TTL toward the stored deadline instead of the flat ~29-day bump, but that never made it to milestones, even though Milestone stores its own deadline too — its keep_alive docstring even claimed otherwise. Fixed that, and gave maintenance-pool a different treatment since pools have no deadline at all: keep_alive there now just extends as far as the network allows in one call, since the whole point of the contract is being open-ended.
Also noticed none of the three keep_alive functions ever touched instance storage, only the record itself. That means a quiet pool or milestone being kept alive perfectly fine could still lose the whole contract once Admin/Treasury/FeeBps expired. Fixed that too.
Added a doc on how Soroban TTL/archival/restoration actually works and what the old 100_000/500_000 numbers translate to in real time per contract, plus tests that advance the ledger sequence directly to prove records survive long idle periods with periodic keep_alive pings (and decay to the bare minimum TTL without them).