Skip to content

Scale keep_alive TTL bumps to match each contract's real lifecycle - #233

Open
avqor wants to merge 2 commits into
MergeFi:mainfrom
avqor:fix/ttl-extension-thresholds
Open

Scale keep_alive TTL bumps to match each contract's real lifecycle#233
avqor wants to merge 2 commits into
MergeFi:mainfrom
avqor:fix/ttl-extension-thresholds

Conversation

@avqor

@avqor avqor commented Aug 30, 2026

Copy link
Copy Markdown

Closes #11


escrow's keep_alive/extend_deadline already scale TTL toward the stored deadline instead of the flat ~29-day bump, but that never made it to milestones, even though Milestone stores its own deadline too — its keep_alive docstring even claimed otherwise. Fixed that, and gave maintenance-pool a different treatment since pools have no deadline at all: keep_alive there now just extends as far as the network allows in one call, since the whole point of the contract is being open-ended.

Also noticed none of the three keep_alive functions ever touched instance storage, only the record itself. That means a quiet pool or milestone being kept alive perfectly fine could still lose the whole contract once Admin/Treasury/FeeBps expired. Fixed that too.

Added a doc on how Soroban TTL/archival/restoration actually works and what the old 100_000/500_000 numbers translate to in real time per contract, plus tests that advance the ledger sequence directly to prove records survive long idle periods with periodic keep_alive pings (and decay to the bare minimum TTL without them).

@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

@avqor is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

@avqor
avqor force-pushed the fix/ttl-extension-thresholds branch from 05bcee5 to b512ed8 Compare August 30, 2026 19:17
@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@avqor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@avqor avqor changed the title Scale keep_alive TTL bumps to each contract's real lifecycle Scale keep_alive TTL bumps to match each contract's real lifecycle Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixed TTL extension thresholds risk archival/fund-inaccessibility for long-lived escrows and pools

1 participant