Skip to content

fix(ui): use shared formatCurrency in StatCard to deduplicate currency formatting (fixes #261) #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XueyuanPang-Google wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): use shared formatCurrency in StatCard to deduplicate currency formatting (fixes #261) #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/components/ui/StatCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* always available via the title attribute (keyboard-navigable, hover tooltip).
*/

import { cn } from "@/lib/utils";
import { cn, formatCurrency } from "@/lib/utils";
import { ArrowUpRight, ArrowDownRight, AlertCircle } from "lucide-react";
import type { LucideIcon } from "lucide-react";
import { Sparkline } from "./Sparkline";
Expand Down Expand Up @@ -79,10 +79,7 @@ function formatValue(
switch (format) {
case "currency": {
const maxDecimals = asset === "XLM" ? 7 : 2;
const formatted = value.toLocaleString("en-US", {
maximumFractionDigits: maxDecimals,
});
const display = `${formatted} ${asset}`;
const display = formatCurrency(value, asset);
// Exact value for tooltip shows full asset-specific precision
const exact = `${value.toLocaleString("en-US", { maximumFractionDigits: maxDecimals })} ${asset}`;
return { display, exact };
Expand Down